Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Better support for automated tests in jiterpreter; more opcodes #82281

Merged
merged 4 commits into from
Feb 17, 2023

Conversation

kg
Copy link
Member

@kg kg commented Feb 17, 2023

  • Rearrange the jiterpreter's compile and enter logic so that we enter a trace immediately after compiling it. If you set the minimum hit count to 1 and disable tiering, this appears to run most automated tests in the jiterpreter, which is useful for verifying opcode implementations and flushing out bugs.
  • Move the 'do we need to safepoint after this trace?' logic from the end of enter_jiterpreter into the traces themselves now that traces can perform safepoints. Should improve performance for short traces.
  • Implemented a few more opcodes that looked worthwhile based on statistics.

@ghost
Copy link

ghost commented Feb 17, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Rearrange the jiterpreter's compile and enter logic so that we enter a trace immediately after compiling it. If you set the minimum hit count to 1 and disable tiering, this appears to run most automated tests in the jiterpreter, which is useful for verifying opcode implementations and flushing out bugs.
  • Move the 'do we need to safepoint after this trace?' logic from the end of enter_jiterpreter into the traces themselves now that traces can perform safepoints. Should improve performance for short traces.
  • Implemented a few more opcodes that looked worthwhile based on statistics.
Author: kg
Assignees: -
Labels:

arch-wasm, area-Codegen-Jiterpreter-mono

Milestone: -

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants