Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RID for Ubuntu 23.04 #82284

Merged
merged 4 commits into from
Mar 3, 2023
Merged

add RID for Ubuntu 23.04 #82284

merged 4 commits into from
Mar 3, 2023

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Feb 17, 2023

it seems like #82204 fixed the generation. Alpine diff is big but it seems just some changes in ordering.

@wfurt wfurt self-assigned this Feb 17, 2023
@ghost
Copy link

ghost commented Feb 17, 2023

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

it seems like #82204 fixed the generation. Alpine diff is big but it seems just some changes in ordering.

Author: wfurt
Assignees: wfurt
Labels:

area-Meta

Milestone: -

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this failure related?

src/native/corehost/corehost.proj(93,5): error MSB3073: (NETCORE_ENGINEERING_TELEMETRY=Build)
The command ""/Users/runner/work/1/s/src/native/corehost/build.sh" Debug x64 -apphostver "8.0.0-ci"
 -hostver "8.0.0-ci" -fxrver "8.0.0-ci" -policyver "8.0.0-ci" -commithash "4af962d6cc39903cf2d361b26abaf2d4bf5b9d78"
-os osx -cmakeargs "-DVERSION_FILE_PATH=/Users/runner/work/1/s/artifacts/obj/_version.c" -runtimeflavor mono
-outputrid osx-x64" exited with code 1.

@wfurt
Copy link
Member Author

wfurt commented Feb 17, 2023

It does not seems to @carlossanlop

Checking prerequisites...
  Please install pkg-config before running this script, see https://github.com/dotnet/runtime/blob/main/docs/workflow/requirements/macos-requirements.md

looks like infrastructure issue to me. I can hold on until the tests are clean. There is no rush for main AFAIK.

@wfurt
Copy link
Member Author

wfurt commented Feb 17, 2023

failure tracked as #82240

@carlossanlop

This comment was marked as resolved.

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

I marked my previous comment as resolved. My bad. I didn't see the info message above the failed core-host error.

@tmds
Copy link
Member

tmds commented Mar 2, 2023

@wfurt I know it's required practice to add these. I don't think these rids are particularly useful.

For source-build purposes: NET 7+ builds when the rid is not known up-front. Adding rids is only needed for .NET 6 at this point.

Adding rids to .NET 7+ is for the purpose of making Microsoft portable builds capable of consuming artifacts that target these rids.

Ubuntu 23.04 goes EOL after 9 months, that means it supported for only 3 months of the .NET 8 lifetime (main branch).
I doubt there will ever be any artifacts created that target it.

I think it's similar for the Fedora rids: Fedora releases are only supported for 13 months, and new releases come every 6 months. So trying to target and follow such a rid is a pain.

I hope @richlander's plans for a simplified rid model will bring an improvement for .NET 8.

cc @omajid

@wfurt
Copy link
Member Author

wfurt commented Mar 3, 2023

While I agree @tmds I wanted this for consistency with maintenance branches.

@ghost ghost locked as resolved and limited conversation to collaborators Apr 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants