Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] System.Console: allow terminfo files to be larger than 4KiB. #82433

Merged
merged 1 commit into from
Mar 8, 2023
Merged

[release/6.0] System.Console: allow terminfo files to be larger than 4KiB. #82433

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/libraries/System.Console/src/System/TermInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,9 +258,8 @@ private static bool TryOpen(string filePath, [NotNullWhen(true)] out SafeFileHan
// Read in all of the terminfo data
long termInfoLength = Interop.CheckIo(Interop.Sys.LSeek(fd, 0, Interop.Sys.SeekWhence.SEEK_END)); // jump to the end to get the file length
Interop.CheckIo(Interop.Sys.LSeek(fd, 0, Interop.Sys.SeekWhence.SEEK_SET)); // reset back to beginning
const int MaxTermInfoLength = 4096; // according to the term and tic man pages, 4096 is the terminfo file size max
const int HeaderLength = 12;
if (termInfoLength <= HeaderLength || termInfoLength > MaxTermInfoLength)
if (termInfoLength <= HeaderLength)
{
throw new InvalidOperationException(SR.IO_TermInfoInvalid);
}
Expand Down