Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] delete unused mono_wasm_* functions #82767

Merged
merged 3 commits into from
Mar 1, 2023
Merged

[browser] delete unused mono_wasm_* functions #82767

merged 3 commits into from
Mar 1, 2023

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Feb 28, 2023 •
edited
Loading

  • delete unused mono_wasm_get_icudt_name
  • delete unused mono_wasm_array_length
  • delete unused GlobalizationNative_GetICUDTName

@pavelsavara pavelsavara added this to the 8.0.0 milestone Feb 28, 2023
@pavelsavara pavelsavara self-assigned this Feb 28, 2023
@ghost
Copy link

ghost commented Feb 28, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

delete unused mono_wasm_get_icudt_name

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone: 8.0.0

@pavelsavara pavelsavara changed the title [browser] delete unused mono_wasm_get_icudt_name [browser] delete unused mono_wasm_* functions Feb 28, 2023
This was referenced Feb 28, 2023
Closed
Closed
@build-analysis build-analysis bot mentioned this pull request Feb 28, 2023
Closed
@pavelsavara pavelsavara marked this pull request as ready for review March 1, 2023 07:52
@pavelsavara
Copy link
Member Author

CI failures are unrelated

@pavelsavara pavelsavara merged commit e50633d into dotnet:main Mar 1, 2023
This was referenced Mar 1, 2023
Open
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Mar 31, 2023
@pavelsavara pavelsavara deleted the browser_cleanup_icu branch September 2, 2024 15:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ilonatommy ilonatommy ilonatommy approved these changes

@maraf maraf maraf approved these changes

@radekdoulik radekdoulik radekdoulik approved these changes

@radical radical radical approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@kg kg Awaiting requested review from kg

@marek-safar marek-safar Awaiting requested review from marek-safar

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@pavelsavara @radical @radekdoulik @maraf @ilonatommy