Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventPipe lock implementation #82790

Merged
merged 2 commits into from
Mar 2, 2023
Merged

EventPipe lock implementation #82790

merged 2 commits into from
Mar 2, 2023

Conversation

LakshanF
Copy link
Contributor

Uses CrstStatic as the locking mechanism for NativeAOT EventPipe.

@LakshanF LakshanF added this to the 8.0.0 milestone Feb 28, 2023
@ghost ghost assigned LakshanF Feb 28, 2023
@ghost
Copy link

ghost commented Feb 28, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Uses CrstStatic as the locking mechanism for NativeAOT EventPipe.

Author: LakshanF
Assignees: -
Labels:

area-NativeAOT-coreclr

Milestone: 8.0.0

@LakshanF LakshanF marked this pull request as draft February 28, 2023 20:56
@LakshanF LakshanF requested a review from VSadov February 28, 2023 22:52
@LakshanF
Copy link
Contributor Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LakshanF
Copy link
Contributor Author

LakshanF commented Mar 1, 2023

The extra-platform NativeAOT failures (win-x64) seems unrelated with large number of Cryptography failures and some Http functional ones.

@LakshanF LakshanF marked this pull request as ready for review March 1, 2023 17:35
Copy link
Member

@VSadov VSadov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@VSadov
Copy link
Member

VSadov commented Mar 2, 2023

New changes look good. :shipit:

@MichalStrehovsky
Copy link
Member

No hay más extremos disponibles desde el asignador de extremos

This is #74838 and unrelated (assuming all the failures are this - didn't check - one of the problems with noisy failure modes like this is that it's easy to miss the one relevant regression if there is one).

@LakshanF LakshanF merged commit cc8f02a into dotnet:main Mar 2, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants