Simplify IndexOfAnyAsciiByteValues for needles with 0 on X86 #82866
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IndexOfAnyLookupCore
already discards non-ASCII byte values.We have to do this special-casing of 0 for char inputs because of how we pack the source on X86, but it's redundant when dealing with byte inputs where we do no such packing.
@stephentoub this will further improve your change in #82789 that hits this case.
For values that contain 0: