Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only call base.DisposeAsync on classes derived from FileStream #82874

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Only call base.DisposeAsync on classes derived from FileStream #82874

merged 2 commits into from
Apr 4, 2023

Conversation

jozkee
Copy link
Member

@jozkee jozkee commented Mar 2, 2023

Regression introduced on #65899.

Fixes #82176.
Fixes #82186.

@jozkee jozkee requested review from stephentoub and adamsitnik March 2, 2023 01:58
@jozkee jozkee mentioned this pull request Mar 2, 2023
Closed
@ghost ghost assigned jozkee Mar 2, 2023
@ghost
Copy link

ghost commented Mar 2, 2023

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Regression introduced on #65899.

Fixes #82176.
Fixes #82186.

Author: Jozkee
Assignees: -
Labels:

area-System.IO
Milestone: -

This was referenced Mar 2, 2023
Closed
Closed
Open
Closed
@runfoapp runfoapp bot mentioned this pull request Mar 2, 2023
Closed
@jozkee jozkee requested review from steveharter and wfurt March 22, 2023 21:56
@build-analysis build-analysis bot mentioned this pull request Mar 23, 2023
Closed
wfurt
wfurt approved these changes Mar 24, 2023
View reviewed changes
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I'm wondering if we can write test that verifies that the file is actually closed ... perhaps by using exclusive access and opening int again after DisposeAsync or using pipes on Unix and checking EOF. Setting the CloseInvoked may be sufficient.

@jozkee
Copy link
Member Author

jozkee commented Apr 4, 2023

I'm wondering if we can write test that verifies that the file is actually closed ... perhaps by using exclusive access and opening int again after DisposeAsync or using pipes on Unix and checking EOF.

Not saying we shouldn't but I think CloseInvoked does suffice. Thanks for the review!

@jozkee jozkee merged commit 17a3ebd into main Apr 4, 2023
@jozkee jozkee deleted the fs_issue_82186_v2 branch April 4, 2023 15:22
@ghost ghost locked as resolved and limited conversation to collaborators May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pharring pharring pharring left review comments

@wfurt wfurt wfurt approved these changes

@stephentoub stephentoub Awaiting requested review from stephentoub

@adamsitnik adamsitnik Awaiting requested review from adamsitnik

@steveharter steveharter Awaiting requested review from steveharter

Assignees

@jozkee jozkee

Labels
area-System.IO
Projects
None yet
Milestone
No milestone
3 participants
@jozkee @pharring @wfurt