-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser] new EmccEnableAssertions and EmccEnvironment MSBuild props #82954
Conversation
Tagging subscribers to 'arch-wasm': @lewing Issue Details
Usage:
Fixes #62708 Tested with latest Blazor locally
|
# Conflicts: # src/mono/wasm/runtime/startup.ts
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with the caveat that I'm not an expert on the debugging bits
Co-authored-by: Ankit Jain <radical@gmail.com>
# Conflicts: # src/mono/wasm/build/WasmApp.Native.targets # src/mono/wasm/runtime/dotnet.d.ts # src/mono/wasm/runtime/startup.ts # src/mono/wasm/runtime/types/emscripten.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
Co-authored-by: Marek Fišera <mara@neptuo.com>
There was probably unrelated Edit: yes, flaky test |
Failures are known 'NuGet-Migrations' |
EmccEnableAssertions
boolean_EmccAssertionLevelDefault
EmccEnvironment
comma separated list. Defaultweb,webview,worker,node,shell
.Module.FS_readFile
dotnet.js.symbols
into non-VFS asset. Now it's loaded before mono starts.EmccExportedLibraryFunction
forDEFAULT_LIBRARY_FUNCS_TO_INCLUDE
Usage:
Fixes #62708
Fixes #74346
Related dotnet/aspnetcore#13915
Tested with latest Blazor locally