Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Fix PAX extended attribute reading logic to treat '=' character as valid in the value strings. #83177

Merged
merged 5 commits into from
Mar 10, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Bug fix: Do not fail when reading an extended attribute when the valu…
…e contains an '=' character.,
  • Loading branch information
carlossanlop authored and github-actions committed Mar 9, 2023
commit 7318a76db7d043a3d3df170282739155385e9092
Original file line number Diff line number Diff line change
@@ -735,12 +735,6 @@ private static bool TryGetNextExtendedAttribute(
ReadOnlySpan<byte> keySlice = line.Slice(0, equalPos);
ReadOnlySpan<byte> valueSlice = line.Slice(equalPos + 1);

// If the value contains an =, it's malformed.
if (valueSlice.IndexOf((byte)'=') >= 0)
{
return false;
}

// Return the parsed key and value.
key = Encoding.UTF8.GetString(keySlice);
value = Encoding.UTF8.GetString(valueSlice);