[release/6.0] [mono] Use unsigned char when computing UTF8 string hashes #83303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
vargaz,
lambdageek and
thaystg
as code owners
lambdageek
changed the title
lambdageek
added
area-Codegen-AOT-mono
Servicing-consider
github-actions
bot
force-pushed
the
backport/pr-83302-to-release/6.0
branch
from
94292ee
to
7b786c2
Compare
|
Hello - Today is code-complete day for merging changes that should go into the April servicing release. Todos:
If it's not critical to get it merged in the April release, we can wait until next month. |
github-actions
bot
force-pushed
the
backport/pr-83302-to-release/6.0
branch
from
7b786c2
to
0e4ca74
Compare
The C standard does not specify whether `char` is signed or unsigned, it is implementation defined. Apparently Android aarch64 makes a different choice than other platforms (at least macOS arm64 and Windows x64 give different results). Mono uses `mono_metadata_str_hash` in the AOT compiler and AOT runtime to optimize class name lookup. As a result, classes whose names include UTF-8 continuation bytes (with the high bit = 1) will hash differently in the AOT compiler and on the device. Fixes #82187 Fixes #78638
lambdageek
force-pushed
the
backport/pr-83302-to-release/6.0
branch
from
0e4ca74
to
e6dd087
Compare
leecow
added
Servicing-approved
thaystg
approved these changes
Mar 28, 2023
vargaz
approved these changes
Mar 28, 2023
This was referenced Mar 28, 2023
carlossanlop
added
Servicing-approved
|
@lambdageek not sure if you saw but the new check-service-labels CI leg was stuck because there were some weird problems with GitHub Actions yesterday. The fix is to remove and readd the |
lambdageek
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #83273 to release/6.0
Resolves #82187
Resolves #78638
The corresponding 7.0 PR is #83302
Customer Impact
Resolves crashes in Release builds of Android apps that include classes with non-ASCII names that use AOT compilation.
Testing
Manual testing. New regression test.
Risk
Low. For code that uses ASCII names the hash code computation is unchanged.