Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct documentation comment for IMultiplyOperators returns #83693

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

IDisposable
Copy link
Contributor

Replaced divided-by with multiplied-by in both IMultiplyOperators.cs and NFloat.cs to fix some copy-paste errors.
Fixes #80521

Replaced _divided-by_ with _multiplied-by_ in both
IMultiplyOperators.cs and NFloat.cs.
Fixes dotnet#80521
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Mar 20, 2023
@IDisposable
Copy link
Contributor Author

IDisposable commented Mar 20, 2023

PR for documentation here.

IDisposable added a commit to IDisposable/dotnet-api-docs that referenced this pull request Mar 20, 2023
Replaced _divided-by_ with _multiplied-by_ in
System.Half, System.Int128, System.UInt128,
System.Numerics.IMultiplyOperators, and
System.Runtime.InteropServices.NFloat.
This reflects the matching changes in
dotnet/runtime#83693 to the
IMultiplyOperators and NFloat and
fixes dotnet/runtime#80521
@IDisposable
Copy link
Contributor Author

IDisposable commented Mar 20, 2023

This should be area-System.Numerics for @jeffhandley attention

AaronRobinsonMSFT pushed a commit to dotnet/dotnet-api-docs that referenced this pull request Mar 20, 2023
Replaced _divided-by_ with _multiplied-by_ in
System.Half, System.Int128, System.UInt128,
System.Numerics.IMultiplyOperators, and
System.Runtime.InteropServices.NFloat.
This reflects the matching changes in
dotnet/runtime#83693 to the
IMultiplyOperators and NFloat and
fixes dotnet/runtime#80521
@ghost
Copy link

ghost commented Mar 21, 2023

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

Replaced divided-by with multiplied-by in both IMultiplyOperators.cs and NFloat.cs to fix some copy-paste errors.
Fixes #80521

Author: IDisposable
Assignees: -
Labels:

area-System.Numerics, community-contribution

Milestone: -

@tannergooding tannergooding merged commit 7b65174 into dotnet:main Mar 21, 2023
@danmoseley
Copy link
Member

Thanks @IDisposable

@ghost ghost locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Numerics community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation Comments for IMultiplyOperators`3 mention division.
3 participants