Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move optimize bools pass to a new file #83768

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Conversation

a74nh
Copy link
Contributor

@a74nh a74nh commented Mar 22, 2023

No code changes, just moving.

No code changes, just moving.
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Mar 22, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 22, 2023
@ghost
Copy link

ghost commented Mar 22, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

No code changes, just moving.

Author: a74nh
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution

Milestone: -

@a74nh
Copy link
Contributor Author

a74nh commented Mar 22, 2023

This change was originally in #79283, but was moved out for simplifying the review.

The optimize bools pass is now bigger than the if conversion pass, so it made sense to move to it's own file.

@a74nh
Copy link
Contributor Author

a74nh commented Mar 22, 2023

@kunalspathak and @jakobbotsch

Copy link
Member

@jakobbotsch jakobbotsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jakobbotsch jakobbotsch merged commit 71b0ecd into dotnet:main Mar 22, 2023
@a74nh a74nh deleted the runtime_file branch March 22, 2023 13:13
@ghost ghost locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants