Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/6.0] Use CLOCK_BOOTTIME to calculate BootTime on linux (#67589) #83965

Merged
merged 6 commits into from
Mar 31, 2023
Merged

[release/6.0] Use CLOCK_BOOTTIME to calculate BootTime on linux (#67589) #83965

merged 6 commits into from
Mar 31, 2023

Conversation

simonrozsival
Copy link
Member

Backport of #67589 to release/6.0

/cc @am11 @adamsitnik

Customer impact

A customer reported that they can't use the Process.StartTime API in their Android app (#83816). The problem is that recent Android versions don't allow reading the /proc/stat file anymore. Instead, we use the clock_gettime libc function.

This bug as already been fixed in .NET 8 but we didn't backport it to .NET 6.0 at that time. The .NET 6.0 MAUI support lasts until the end of May 2023 so we should backport this bugfix.

Fixes #83816

Testing

Manual testing and unit tests.

Risk

Low. The fix is well tested.

dotnet-maestro bot and others added 3 commits March 23, 2023 17:34
@dotnet-maestro
Update dependencies from https://github.com/dotnet/emsdk build 202303…
f2db6d6 
…23.2 (dotnet#83857)

Microsoft.NET.Workload.Emscripten.Manifest-6.0.100 , Microsoft.NET.Workload.Emscripten.Manifest-6.0.300 , Microsoft.NET.Workload.Emscripten.Manifest-6.0.400
 From Version 6.0.15 -> To Version 6.0.16

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@am11 @adamsitnik
@jeffhandley @simonrozsival
Use CLOCK_BOOTTIME to calculate BootTime on linux (dotnet#67589)
f45eca8 
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
Co-authored-by: Simon Rozsival <simon@rozsival.com>
@simonrozsival
Replace LibraryImport with DllImport in .NET 6.0
cca5076
@simonrozsival simonrozsival added Servicing-consider Issue for next servicing release review area-System.Diagnostics.Process labels Mar 27, 2023
@simonrozsival simonrozsival added this to the 6.0.x milestone Mar 27, 2023
@ghost ghost assigned simonrozsival Mar 27, 2023
@ghost
Copy link

ghost commented Mar 27, 2023

Tagging subscribers to this area: @dotnet/area-system-diagnostics-process
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #67589 to release/6.0

/cc @am11 @adamsitnik

Customer impact

A customer reported that they can't use the Process.StartTime API in their Android app (#83816). The problem is that recent Android versions don't allow reading the /proc/stat file anymore. Instead, we use the clock_gettime libc function.

This bug as already been fixed in .NET 8 but we didn't backport it to .NET 6.0 at that time. The .NET 6.0 MAUI support lasts until the end of May 2023 so we should backport this bugfix.

Fixes #83816

Testing

Manual testing and unit tests.

Risk

Low. The fix is well tested.

Author: simonrozsival
Assignees: -
Labels:

Servicing-consider, area-System.Diagnostics.Process
Milestone: 6.0.x

@build-analysis build-analysis bot mentioned this pull request Mar 27, 2023
Closed
@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Mar 28, 2023
@rbhanda rbhanda modified the milestones: 6.0.x, 6.0.16, 6.0.17 Mar 28, 2023
@simonrozsival simonrozsival changed the base branch from release/6.0 to release/6.0-staging March 28, 2023 20:02
@simonrozsival simonrozsival changed the base branch from release/6.0-staging to release/6.0 March 28, 2023 20:02
@carlossanlop
Copy link
Member

I'm retargeting this PR to the new release/6.0-staging branch, which is the one that we will use from now on for servicing fixes.

Repo maintainers will now be allowed to merge their own servicing PR as long as it meets the requirements:

  • It is approved by Tactics (signaled by adding the Servicing-approved label).
  • It's signed-off by an area owner.
  • The CI is green, or the failures are investigated as unrelated.
  • And if the PR touches an OOB package, the necessary OOB authoring changes are added.

The new process is described here: runtime/docs/project/library-servicing.md.

The infra team will be actively monitoring servicing PRs to ensure all requirements are met and to help with any issues.

Let me know if you have any questions.

@carlossanlop carlossanlop changed the base branch from release/6.0 to release/6.0-staging March 28, 2023 21:07
This was referenced Mar 29, 2023
Closed
Closed
Closed
Closed
Closed
@simonrozsival
Copy link
Member Author

simonrozsival commented Mar 29, 2023 •
edited
Loading

Thanks, @carlossanlop.

@simonrozsival simonrozsival marked this pull request as draft March 29, 2023 12:52
@simonrozsival
Copy link
Member Author

@runfoapp runfoapp bot mentioned this pull request Mar 29, 2023
Closed
@simonrozsival simonrozsival marked this pull request as ready for review March 30, 2023 07:38
@carlossanlop
Copy link
Member

carlossanlop commented Mar 30, 2023 •
edited by simonrozsival
Loading

@simonrozsival you are free to merge into the staging branches anytime, as soon as you meet the requirements:

  • Sign-off by area owner.
  • No OOB changes needed for the involved assemblies. System.Diagnostics.Process does not have IsPackable set to true.
  • Approved by Tactics. Mandatory Servicing-approved label applied.
  • CI is green.

The Code-complete date for the May 2023 Release is April 10th.

adamsitnik
adamsitnik approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @simonrozsival !

@simonrozsival simonrozsival merged commit cfa7b27 into dotnet:release/6.0-staging Mar 31, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Apr 30, 2023
@leecow leecow modified the milestones: 6.0.17, 6.0.18 Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adamsitnik adamsitnik adamsitnik approved these changes

Assignees

@simonrozsival simonrozsival

Labels
area-System.Diagnostics.Process Servicing-approved Approved for servicing release
Projects
None yet
Milestone
6.0.18
Development

Successfully merging this pull request may close these issues.
6 participants
@simonrozsival @carlossanlop @adamsitnik @leecow @rbhanda @am11