Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HybridGlobalization info from linker feature switches #84073

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

mkhamoyan
Copy link
Contributor

@mkhamoyan mkhamoyan commented Mar 29, 2023

As discussed in #81470 (comment) , feature switches listed in feature-switches.md are linker feature switches.
HybridGlobalization is a regular AppContext switch and shouldn't be here.

@ghost
Copy link

ghost commented Mar 29, 2023

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

As discusses in #81470 (comment) , feature switches listed in feature-switches.md are linker feature switches.
HybridGlobalization is a regular AppContext switch and shouldn't be here.

Author: mkhamoyan
Assignees: mkhamoyan
Labels:

area-Meta

Milestone: -

@ghost
Copy link

ghost commented Mar 29, 2023

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

As discusses in #81470 (comment) , feature switches listed in feature-switches.md are linker feature switches.
HybridGlobalization is a regular AppContext switch and shouldn't be here.

Author: mkhamoyan
Assignees: mkhamoyan
Labels:

area-Meta, area-System.Globalization

Milestone: -

@mkhamoyan mkhamoyan added the os-ios Apple iOS label Mar 29, 2023
Copy link
Member

@ilonatommy ilonatommy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to @akoeplinger features listed here are only linker features. I do not agree that PredefinedCulturesOnly is a linker feature, to my understanding it does not result in trimming code but in throwing an exception. Should we remove it as well?

@akoeplinger
Copy link
Member

PredefinedCulturesOnly is a linker feature switch since it has a substitution in

<method signature="System.Boolean get_PredefinedCulturesOnly()" body="stub" value="true" feature="System.Globalization.PredefinedCulturesOnly" featurevalue="true" />

That means when the switch is turned on the substitution happens and the binary gets trimmed differently.

@akoeplinger akoeplinger merged commit 7e8f438 into main Mar 29, 2023
@akoeplinger akoeplinger deleted the update_doc_info branch March 29, 2023 13:50
@ghost ghost locked as resolved and limited conversation to collaborators Apr 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants