Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use underlying type converter for nullable type #84208

Merged
merged 8 commits into from
May 31, 2023
Merged

Use underlying type converter for nullable type #84208

merged 8 commits into from
May 31, 2023

Conversation

pedrobsaila
Copy link
Contributor

Fixes #66547

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Apr 1, 2023
@ghost
Copy link

ghost commented Apr 1, 2023

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #66547

Author: pedrobsaila
Assignees: -
Labels:

area-System.Text.Json
Milestone: -

@build-analysis build-analysis bot mentioned this pull request Apr 1, 2023
Closed
@krwq krwq self-assigned this Apr 3, 2023
@pedrobsaila
Copy link
Contributor Author

Hi @krwq

I'm closing this PR since @eiriktsarpalis already fixed it as part of #84015

see :

https://github.com/dotnet/runtime/blob/bf7fb2ecbf69deb6a73bb8bbca1e56e7beec8d8a/src/libraries/System.Text.Json/gen/JsonSourceGenerator.Emitter.cs#LL243C13-L261C14

@pedrobsaila pedrobsaila deleted the 66547 branch May 30, 2023 19:19
@eiriktsarpalis
Copy link
Member

@pedrobsaila would it be possible to rebase your PR so that the tests that you added can be included? Thanks

@pedrobsaila pedrobsaila restored the 66547 branch May 30, 2023 20:26
@pedrobsaila pedrobsaila reopened this May 30, 2023
eiriktsarpalis
eiriktsarpalis approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed further commits adding runtime tests and making necessary changes to the emitter.

This was referenced May 31, 2023
Closed
Open
@eiriktsarpalis eiriktsarpalis merged commit 2a1b52a into dotnet:main May 31, 2023
@pedrobsaila pedrobsaila deleted the 66547 branch May 31, 2023 13:33
This was referenced Jun 7, 2023
Closed
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

Assignees

@krwq krwq

Labels
area-System.Text.Json community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Json source generator should support JsonConverter on non-nullable and nullable types
3 participants
@pedrobsaila @eiriktsarpalis @krwq