Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config binder generator to ASP.NET Core transport pack #84436

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Add config binder generator to ASP.NET Core transport pack #84436

merged 1 commit into from
Apr 18, 2023

Conversation

layomia
Copy link
Contributor

@layomia layomia commented Apr 6, 2023

@layomia layomia added this to the 8.0.0 milestone Apr 6, 2023
@layomia layomia self-assigned this Apr 6, 2023
@ghost
Copy link

ghost commented Apr 6, 2023

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

Related #84379, dotnet/sdk#31654.
FYI @eerhardt @captainsafia

Author: layomia
Assignees: layomia
Labels:

area-Extensions-Configuration
Milestone: 8.0.0

ericstj
ericstj approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - babysit this one when it hits ASP.NET by letting @wtgodbe know to ping you if it needs help when it hits ASP.NET Core. You might need to manually replicate the exclusion in ASP.NET.

@layomia layomia added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Apr 7, 2023
@layomia
Copy link
Contributor Author

layomia commented Apr 7, 2023

Blocked on dotnet/sdk#31654.

@layomia layomia mentioned this pull request Apr 18, 2023
Merged
@layomia
Copy link
Contributor Author

layomia commented Apr 18, 2023 •
edited
Loading

The enabling mechanism has been added to the SDK in dotnet/sdk#31654.

cc @dotnet/aspnet-build @eerhardt I'll be following to see if there are any issues with ingesting the generator via this transport pack. If needed we could remove the analyzer manually in your build.

@layomia layomia removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Apr 18, 2023
@layomia layomia merged commit 2a0f56c into dotnet:main Apr 18, 2023
@wtgodbe wtgodbe mentioned this pull request Apr 19, 2023
Merged
@layomia layomia added the source-generator Indicates an issue with a source generator feature label May 17, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tarekgh tarekgh tarekgh approved these changes

@ericstj ericstj ericstj approved these changes

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees

@layomia layomia

Labels
area-Extensions-Configuration source-generator Indicates an issue with a source generator feature
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@layomia @ViktorHofer @ericstj @tarekgh