-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Turn Wasm exception handling on by default and use WasmEnableExceptio… #84573
Conversation
…nHandling as the default value for WasmEnableSIMD
fix typo
WBT/node tests failing with:
|
yeah we need to enable the feature for all the host runtimes |
<WasmEnableSIMD Condition="'$(WasmEnableSIMD)' == ''">true</WasmEnableSIMD> | ||
<!-- Post Wasm MVP features --> | ||
<WasmEnableExceptionHandling Condition="'$(WasmEnableExceptionHandling)' == ''">true</WasmEnableExceptionHandling> | ||
<WasmEnableSIMD Condition="'$(WasmEnableSIMD)' == ''">$(WasmEnableExceptionHandling)</WasmEnableSIMD> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious: why to base the default SIMD value on EH value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because it is much less of an improvement without EH and EH is more broadly compatible/deployed than SIMD so if you are explicitly disabling EH you probably want to disable SIMD too, whereas if you were disable SIMD for compat reasons you may not need to disable EH. That was my thought at least
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EH is more broadly compatible/deployed than SIMD
only in Safari. Chrome, Firefox and nodejs have SIMD support longer than EH. (https://webassembly.org/roadmap/)
I think the new behavior is a bit confusing. Maybe we could introduce a new property, like WasmEnableAdvancedFeatures
or WasmEnableNextGen
to switch the defaults of SIMD, EH and other non 1.1 features. What do you think?
Looks fine other than radek's comment |
@radekdoulik should we change the benchmarks to explicitly set these settings based on their name/intension? |
…nHandling as the default value for WasmEnableSIMD