Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure that JSImport/JSExport use fully qualified name for DebuggerNonUserCode #84725

Merged
merged 1 commit into from
Apr 13, 2023
Merged

fix: Ensure that JSImport/JSExport use fully qualified name for DebuggerNonUserCode #84725

merged 1 commit into from
Apr 13, 2023

Conversation

jeromelaban
Copy link
Contributor

Adds a global qualifier to avoid having namespace conflicts if an import or export is declared in a scope that already contains System.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Apr 12, 2023
@lewing lewing closed this Apr 13, 2023
@lewing lewing reopened this Apr 13, 2023
@build-analysis build-analysis bot mentioned this pull request Apr 13, 2023
Closed
@pavelsavara pavelsavara merged commit 42c6bcf into dotnet:main Apr 13, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lewing lewing lewing approved these changes

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara is a code owner

Assignees
No one assigned
Labels
area-System.Runtime.InteropServices.JavaScript community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeromelaban @lewing @pavelsavara