Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve BigInteger operators +, - and * for trivial cases #84733

Merged
merged 4 commits into from
Jul 7, 2023

Commits on Apr 12, 2023

  1. Improve BigInteger operators +, - and * for trivial cases

    Move handling of trivial cases from internal methods with span
    arguments to to the very beginning of public operators. This avoids
    creating unneeded spans, checking them to empty state and some other
    unneeded operations.
    
    Does not affect time of processing non-trivial arguments.
    
    Discussion: dotnet#84721
    speshuric committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    0249a77 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2023

  1. Add assert when both left and right argument's spans are empty

    Address PR feedback.
    speshuric committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    cdaf70a View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Configuration menu
    Copy the full SHA
    62fb7a0 View commit details
    Browse the repository at this point in the history
  2. nit: If this assert ever fails, we need to see the code to understand…

    … why. To avoid that we can make an error message out of the comment. So when it fails, it's printed.
    adamsitnik committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    80c691f View commit details
    Browse the repository at this point in the history