fix(76268): Fix invalid behavior for ignored properties with "new" mo… #84756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsSimple change Dictionary<TKey,TValue>.Add(TKey, TValue) for adding new ignored property to Dictionary<TKey,TValue>.Item[TKey] Fixes #76268
|
|
@jeffhandley , can you review current PR quickly? I think, #66900 linked with the same lines and I want to fix it separately. |
|
@Maximys could you take a look at the test failures? My guess is that the change makes source generation fail in some way e.g. not producing source good to implement the abstract members. |
|
@layomia , ok, I'll try to look at the test failures a bit late. |
Maximys
force-pushed
the
bugfix/76268-fix-invalid-processing-of-jsonignoreattribute
branch
4 times, most recently
from
98033bb
to
42387a7
Compare
|
@layomia , I had just fixed failed tests by amend. Could you review again? |
…difier of derived class.
eiriktsarpalis
force-pushed
the
bugfix/76268-fix-invalid-processing-of-jsonignoreattribute
branch
from
42387a7
to
5f6670a
Compare
Maximys
deleted the
bugfix/76268-fix-invalid-processing-of-jsonignoreattribute
branch
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple change Dictionary<TKey,TValue>.Add(TKey, TValue) for adding new ignored property to Dictionary<TKey,TValue>.Item[TKey]
Fixes #76268