Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser] Wasm SDK packed as a nuget package #84761

Merged
merged 2 commits into from
Apr 14, 2023
Merged

Conversation

maraf
Copy link
Member

@maraf maraf commented Apr 13, 2023

Produce a Microsoft.NET.Sdk.WebAssembly.Pack package containing most of the Wasm SDK bits.

Contributes to #81367
Fixes #84742

@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono labels Apr 13, 2023
@maraf maraf added this to the 8.0.0 milestone Apr 13, 2023
@maraf maraf self-assigned this Apr 13, 2023
@ghost
Copy link

ghost commented Apr 13, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Produce a Microsoft.NET.Sdk.WebAssembly.Pack package containing most of the Wasm SDK bits.
Original PR #84082

  • Original sources https://github.com/dotnet/sdk/tree/main/src/WasmSdk
  • This PR tries to make a minimal change
  • Tests and integration with in-tree building will come in follow-up PRs
  • Update pattern for matching RidAgnosticNupkgToPublishFile to include Microsoft.NET.Sdk.WebAssembly.Pack

Contributes to #81367

Author: maraf
Assignees: maraf
Labels:

arch-wasm, area-Build-mono

Milestone: 8.0.0

@maraf
Copy link
Member Author

maraf commented Apr 13, 2023

@maraf
Copy link
Member Author

maraf commented Apr 13, 2023

The official build has completed and I have validated in binlog that the items collection ItemsToPush contains Microsoft.NET.Sdk.WebAssembly.Pack. The task PushToAzureDevOpsArtifacts doesn't run for branch build.

Failures are not related

@lewing This is ready to merge

@maraf
Copy link
Member Author

maraf commented Apr 13, 2023

We should wait for this dotnet/sdk#31559 to land in SDK and update StaticWebAssets binding

@lewing lewing merged commit 27b8a24 into dotnet:main Apr 14, 2023
@maraf maraf deleted the WasmSdkPackaged2 branch April 14, 2023 06:50
@ghost ghost locked as resolved and limited conversation to collaborators May 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Official build failure trying to sign Microsoft.NET.Sdk.WebAssembly.Pack
2 participants