Flow TasksConfiguration in build & specify generator config #84931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elinor-fung did you had a chance to look at this PR? |
|
Sorry - I was oof. I'll take a look today or tomorrow. |
elinor-fung
reviewed
May 2, 2023
|
@ViktorHofer did you have a chance to get back to this? Since it fixes binclashes that could affect shipping bits, we'd like to get it fixed for 8. I can also take a look if you are heads down on other things. |
|
I'm out this week but can take a look next week. Sorry for the delay. I will make sure that this is ready before we branch off. |
… CI/official builds(dotnet#84488)
1. Flow the TasksConfiguration in the root build (Subsets.props) 2. Specify the LibrariesConfiguration explicitly when building the LibraryImport source generators. 3. Set tasks configuration to debug by default.
ViktorHofer
force-pushed
the
SetTasksConfigurationCorrectly
branch
from
6d423e7 to
8733c9c
Compare
3 tasks
|
@elinor-fung the PR is now ready. We still have two double writes but those are unrelated and I filed #89763 for it. |
elinor-fung
approved these changes
Aug 1, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84157
Builds on top of the previous state of #84666
LibraryImport source generators.
@elinor-fung I worked on that mid last week and hadn't found time to push. I think this is a slightly better approach as it uses the common path (Debug/Release config for tasks) and makes sure that the TasksConfiguration and the LibrariesConfiguration is available in when triggered from a root build. This builds on top of your existing work which looked really good.