Add NativeAOT runtime pack build for iOS/tvOS/Catalyst #85047
Conversation
ghost
assigned 
akoeplinger
force-pushed
the
nativeaot-runtimepack
branch
from
a7626ef
to
fb651ae
Compare
|
What is going to be the name of this runtime pack? |
Similar to how we include mono in the runtime packs. |
|
@akoeplinger official build looks good https://dev.azure.com/dnceng/internal/_build/results?buildId=2162257&view=results |
Is the AOT compiler going to stay in Microsoft.DotNet.ILCompiler? I am wondering whether it would make sense to do the same change for all hosts and targets. |
src/installer/pkg/sfx/Microsoft.NETCore.App/Directory.Build.props
Outdated
Show resolved
Hide resolved
| <PlatformManifestFileEntry Include="System.Private.DisabledReflection.dll" /> | ||
| <PlatformManifestFileEntry Include="System.Private.Reflection.Execution.dll" /> | ||
| <PlatformManifestFileEntry Include="System.Private.StackTraceMetadata.dll" /> | ||
| <PlatformManifestFileEntry Include="System.Private.TypeLoader.dll" /> |
There was a problem hiding this comment.
Why are these needed? I thought NativeAOT ships as native binary?
Is System.Private.Corelib.dll missing in the list?
There was a problem hiding this comment.
These are things that could be in CoreLib but since it doesn't cost anything to have them out of CoreLib, we keep them out of CoreLib. We folded some into CoreLib in the past. We definitely need CoreLib too and it's already include above.
There was a problem hiding this comment.
I see so there is a circular dependency between these and SPC?
There was a problem hiding this comment.
Is System.Private.Corelib.dll missing in the list?
SPC is already included at line 74.
I think it makes sense. Should we also change the name of the mono aot compiler packs? Right now it's |
@jkotas the AOT compiler is going to stay in Microsoft.DotNet.ILCompiler, or at least I don't see a reason why we should move it. We can make the runtime pack change for all hosts/targets, I just started with the new platforms so the risk is lower. |
Contributes to #81024
This is the first part that adds runtime packs to the build.