Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable option to use the Windows ThreadPool #85373

Merged
merged 172 commits into from
Jun 15, 2023

Conversation

eduardo-vp
Copy link
Member

@eduardo-vp eduardo-vp commented Apr 26, 2023

When running on Windows, enable an option to switch between the Portable thread pool and the Windows thread pool.

This change targets NativeAOT, CoreCLR, and Mono.

Windows threadpool remains as the default for NativeAOT on Windows. For any other case the Portable thread pool remains the default.

Tests with the Windows thread pool enabled were added to the System.Threading.Threadpool solution.

Trimming is enabled to remove the unused thread pool.

@eduardo-vp
Copy link
Member Author

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@eduardo-vp
Copy link
Member Author

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@eduardo-vp eduardo-vp force-pushed the feature/enable-windows-threadpool branch from eb2c12b to 3646176 Compare June 2, 2023 19:25
@eduardo-vp eduardo-vp force-pushed the feature/enable-windows-threadpool branch from cff36df to 56be9f1 Compare June 5, 2023 15:24
Copy link
Member

@kouvel kouvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments, otherwise LGTM, thanks!

@eduardo-vp eduardo-vp marked this pull request as ready for review June 7, 2023 15:14
@eduardo-vp eduardo-vp merged commit 0a0fa13 into dotnet:main Jun 15, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jul 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants