Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0-preview4] Bump package version for .net 7 to 7.0.6 #85418

Merged
merged 2 commits into from
Apr 28, 2023
Merged

[release/8.0-preview4] Bump package version for .net 7 to 7.0.6 #85418

merged 2 commits into from
Apr 28, 2023

Conversation

steveisok
Copy link
Member

No description provided.

@ghost ghost assigned steveisok Apr 26, 2023
@ghost
Copy link

ghost commented Apr 26, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: steveisok
Assignees: steveisok
Labels:

area-Infrastructure-libraries
Milestone: -

@steveisok
Copy link
Member Author

@carlossanlop this is a tell mode change.

carlossanlop
carlossanlop approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@steveisok should I update my snap checklist to ensure we do this change before snapping? Would that avoid problems in main, or is this change not needed in that branch?

@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Apr 26, 2023
@steveisok
Copy link
Member Author

@steveisok should I update my snap checklist to ensure we do this change before snapping? Would that avoid problems in main, or is this change not needed in that branch?

This should happen when we snap a preview branch to make sure the down level version is lined up. We can't do that in main because we want to run tests and can't if it's set to a version that hasn't been released.

This was referenced Apr 27, 2023
Closed
Open
Closed
Closed
@carlossanlop
Copy link
Member

@steveisok is this ready to merge? CI looks good?

@steveisok
Copy link
Member Author

@carlossanlop it should be good to go once the latest CI run completes.

@mmitche
Copy link
Member

mmitche commented Apr 28, 2023

Pls merge when ready.

@steveisok steveisok merged commit 8e472c8 into dotnet:release/8.0-preview4 Apr 28, 2023
@steveisok steveisok deleted the bump-p4-downlevel branch April 28, 2023 17:32
lewing added a commit that referenced this pull request May 8, 2023
@lewing
Revert "[release/8.0-preview4] Bump package version for .net 7 to 7.0…
9fcf887 
….6 (#85418)"

This reverts commit 8e472c8.
@lewing lewing mentioned this pull request May 8, 2023
Merged
lewing added a commit that referenced this pull request May 8, 2023
@lewing
Revert "[release/8.0-preview4] Bump package version for .net 7 to 7.0…
c74dc62 
….6 (#85418)" (#85929)

This reverts commit 8e472c8.
@ghost ghost locked as resolved and limited conversation to collaborators May 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lewing lewing lewing approved these changes

@carlossanlop carlossanlop carlossanlop approved these changes

Assignees

@steveisok steveisok

Labels
area-Infrastructure-libraries Servicing-approved Approved for servicing release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@steveisok @carlossanlop @mmitche @lewing