Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono][llvm] Assert on unhandled opcodes instead of falling back to t… #85454

Merged
merged 1 commit into from
Apr 28, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/mono/mono/mini/mini-llvm.c
Original file line number Diff line number Diff line change
Expand Up @@ -5840,6 +5840,7 @@ process_bb (EmitContext *ctx, MonoBasicBlock *bb)
case OP_NOT_NULL:
case OP_LIVERANGE_START:
case OP_LIVERANGE_END:
case OP_TAILCALL_PARAMETER:
break;
case OP_ICONST:
values [ins->dreg] = const_int32 (ins->inst_c0);
Expand Down Expand Up @@ -11747,13 +11748,20 @@ MONO_RESTORE_WARNING
}
case OP_IL_SEQ_POINT:
break;
default: {
case OP_ARGLIST:
case OP_TAILCALL:
case OP_TAILCALL_REG:
case OP_TAILCALL_MEMBASE:
case OP_CKFINITE: {
char reason [128];

sprintf (reason, "opcode %s", mono_inst_name (ins->opcode));
set_failure (ctx, reason);
break;
}
default:
g_error ("opcode %d %s", ins->opcode, mono_inst_name (ins->opcode));
break;
}

if (!ctx_ok (ctx))
Expand Down