fix JsonNode deserialising from null #85463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis |
| @@ -39,6 +41,10 @@ public static void JsonTypes_Deserialize() | |||
| Assert.IsAssignableFrom<JsonValue>(JsonNode.Parse("\"str\"")); | |||
| Assert.IsAssignableFrom<JsonValue>(JsonNode.Parse(ToUtf8("\"str\""))); | |||
| Assert.IsType<JsonElement>(JsonSerializer.Deserialize<object>("\"str\"")); | |||
|
|
|||
| Assert.Null(JsonSerializer.Deserialize<JsonNode>("null")); | |||
There was a problem hiding this comment.
Would it be possible to
- Also test deserializing an object containing a
JsonNodeproperty? - Add tests validating the same behavior for
JsonObjectandJsonArray?
This was referenced Apr 27, 2023
|
@adj123 would you mind responding to the CLA bot as well? Thanks! |
|
@dotnet-policy-service agree company="DRW Holdings" |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #85172