Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono][debugger] Support step over and pause multiple times in same line but different columns #85484

Merged
merged 6 commits into from
May 2, 2023

Conversation

thaystg
Copy link
Member

@thaystg thaystg commented Apr 27, 2023

for (int i = 0; i < 10; i++)

StepOverInForStatement.mp4

Also:

  • check memory address before read it on MDBGPROT_CMD_VM_READ_MEMORY
  • new version of MDBGPROT_CMD_STACK_FRAME_SET_VALUES_2, because the offset 0 represents "this" when it's not a static method
  • fix MDBGPROT_CMD_OBJECT_REF_SET_VALUES_BY_FIELD_TOKEN to support setting field value if the field is in a parent class.

@ghost
Copy link

ghost commented Apr 27, 2023

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

for (int i = 0; i < 10; i++)

StepOverInForStatement.mp4

Also:

  • check memory address before read it on MDBGPROT_CMD_VM_READ_MEMORY
  • new version of MDBGPROT_CMD_STACK_FRAME_SET_VALUES_2, because the offset 0 represents "this" when it's not a static method
  • fix MDBGPROT_CMD_OBJECT_REF_SET_VALUES_BY_FIELD_TOKEN to support setting field value if the field is in a parent class.
Author: thaystg
Assignees: thaystg
Labels:

area-Debugger-mono

Milestone: -

@thaystg thaystg requested a review from radical as a code owner April 27, 2023 20:34
@thaystg thaystg changed the title [mono][debugger] Support step over and pause multiple times in a for statement [mono][debugger] Support step over and pause multiple times in same line but different column Apr 27, 2023
@thaystg thaystg changed the title [mono][debugger] Support step over and pause multiple times in same line but different column [mono][debugger] Support step over and pause multiple times in same line but different columns Apr 27, 2023
@thaystg
Copy link
Member Author

thaystg commented Apr 28, 2023

/azp run runtime-wasm-dbgtests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@thaystg thaystg merged commit 39e022d into dotnet:main May 2, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants