[mono][interp] Attempt to devirtualize call if we have type information about this
#85528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrzVlad
requested review from
vargaz,
kotlarmilos,
lambdageek,
SamMonoRT,
thaystg and
marek-safar
as code owners
ghost
assigned 
vargaz
approved these changes
Apr 28, 2023
BrzVlad
force-pushed
the
feature-interp-devirt
branch
from
fcd7acf to
57f48a4
Compare
BrzVlad
force-pushed
the
feature-interp-devirt
branch
from
57f48a4 to
13db70b
Compare
BrzVlad
force-pushed
the
feature-interp-devirt
branch
2 times, most recently
from
f095b07 to
5164fd6
Compare
This was referenced May 11, 2023
This information will be useful to later devirtualize the call
Remove asserts from mono_class_get_virtual_method so we can check a virtual method on any klass, returning NULL if no implementation is found.
It will just return null if a concrete implementation wasn't found.
They can still be overriden
BrzVlad
force-pushed
the
feature-interp-devirt
branch
from
2af5a51 to
b3f1676
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly to address performance problems with code like
EqualityComparer<T>.Default.Equals ()Fixes #82948