Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set pre-decided consecutive registers as busy (again) #85566

Merged
merged 1 commit into from
May 1, 2023

Conversation

kunalspathak
Copy link
Member

@kunalspathak kunalspathak commented Apr 30, 2023

In #84824, I started marking the previous register assigned during copyReg as live. However, the previous register could be part of the consecutive registers that we are about to assign and marking it "live at this location" will make it unavailable to be assigned to the relevant subsequent RefPosition. Start tracking the consecutive refpositions in use and do not mark such refpositions as live. Alternatively, I could delay this decision until the assignment of the particular Refposition, however, at that point we want to make sure that we are not randomly unmarking a register that was marked as "live" and hide any other unseen problem.

Also fixed a AV that was hitting for JitDump because recently we also started doing copyReg for upperVectorRestore and when we print the interval name, we hit AV because interval->relatedInterval is set to nullptr during register assignment.

Fixes: #85426

@ghost ghost assigned kunalspathak Apr 30, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 30, 2023
@ghost
Copy link

ghost commented Apr 30, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: kunalspathak
Assignees: kunalspathak
Labels:

area-CodeGen-coreclr

Milestone: -

@kunalspathak
Copy link
Member Author

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, runtime-coreclr jitstress2-jitstressregs,
runtime-coreclr libraries-jitstress2-jitstressregs, runtime-coreclr jitstressregs, runtime-coreclr libraries-jitstressregs

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@kunalspathak kunalspathak marked this pull request as ready for review May 1, 2023 12:21
@kunalspathak
Copy link
Member Author

@dotnet/jit-contrib

@kunalspathak kunalspathak merged commit 049acec into dotnet:main May 1, 2023
@kunalspathak kunalspathak deleted the consecutive_and_busy branch May 1, 2023 12:29
@ghost ghost locked as resolved and limited conversation to collaborators May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
2 participants