JIT: assert if we see schema mismatches with dynamic pgo data #85898
Conversation
When the profile data comes from dynamic PGO, the spanning tree encoded in the schema produced by an earlier tier should exactly match the spanning tree for the current jit attempt, since the JIT and method IL are identical. (This is not the case for static PGO; that schema may have come from a different JIT and/or different version of IL). Note in release modes we won't assert; instead, we will silently throw the PGO data away. Follow-on change to dotnet#85805 to catch more issues like dotnet#85799.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsWhen the profile data comes from dynamic PGO, the spanning tree encoded in the schema produced by an earlier tier should exactly match the spanning tree for the current jit attempt, since the JIT and method IL are identical. (This is not the case for static PGO; that schema may have come from a different JIT and/or different version of IL). Note in release modes we won't assert; instead, we will silently throw the PGO data away. Follow-on change to #85805 to catch more issues like #85799.
|
|
/azp run runtime-coreclr pgo, runtime-coreclr pgostress, runtme-coreclr libraries-pgo |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run runtime-coreclr libraries-pgo |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Makes sense, LGTM assuming CI failures aren't related |
ghost
locked as resolved and limited conversation to collaborators
When the profile data comes from dynamic PGO, the spanning tree encoded in the schema produced by an earlier tier should exactly match the spanning tree for the current jit attempt, since the JIT and method IL are identical.
(This is not the case for static PGO; that schema may have come from a different JIT and/or different version of IL).
Note in release modes we won't assert; instead, we will silently throw the PGO data away.
Follow-on change to #85805 to catch more issues like #85799.