Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete GT_CNS_LNG #85951

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Delete GT_CNS_LNG #85951

wants to merge 7 commits into from

Conversation

SingleAccretion
Copy link
Contributor

GT_CNS_LNG is an oper used for integral constants on 32 bit targets. On 64 bit targets, GT_CNS_INT is used for all integral constants. This is a bit of a hindrance for 32 bit target CQ, as it forces the natural flow of code to not consider long constants, and in general it seems odd to have one of the fundamental IR concepts (integer constants) be target-specific.

This change deletes GT_CNS_LNG, in favor of representing all integer constants with GT_CNS_INT.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label May 8, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 8, 2023
@ghost
Copy link

ghost commented May 8, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

GT_CNS_LNG is an oper used for integral constants on 32 bit targets. On 64 bit targets, GT_CNS_INT is used for all integral constants. This is a bit of a hindrance for 32 bit target CQ, as it forces the natural flow of code to not consider long constants, and in general it seems odd to have one of the fundamental IR concepts (integer constants) be target-specific.

This change deletes GT_CNS_LNG, in favor of representing all integer constants with GT_CNS_INT.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

@SingleAccretion SingleAccretion force-pushed the No-Cns-Lng branch 2 times, most recently from 3653cd1 to b32ad59 Compare May 10, 2023 07:54
@drcjt drcjt mentioned this pull request May 15, 2023
Open
@build-analysis build-analysis bot mentioned this pull request May 25, 2023
Closed
@ghost ghost closed this Jun 24, 2023
@ghost
Copy link

ghost commented Jun 24, 2023

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@ghost ghost closed this Jul 25, 2023
@ghost
Copy link

ghost commented Jul 25, 2023

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@ghost ghost closed this Aug 24, 2023
@ghost
Copy link

ghost commented Aug 24, 2023

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@ghost ghost closed this Sep 24, 2023
@ghost
Copy link

ghost commented Sep 24, 2023

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@ghost
Copy link

ghost commented Feb 25, 2024

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@AndyAyersMS
Copy link
Member

@SingleAccretion probably needs reformatting.

@SingleAccretion
Copy link
Contributor Author

probably needs reformatting.

And not just that. The main problem with this change is that I need to find a way around the small TP regression.

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannergooding tannergooding tannergooding left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SingleAccretion @AndyAyersMS @tannergooding