-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete Windows arm32 support #86065
Delete Windows arm32 support #86065
Conversation
Continuation of #85947 |
|
Presumably we can also close all active win-arm32 issues (not all of them have OS label)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Additional things to remove:
- in root .vsconfig, presumably we can remove "Microsoft.VisualStudio.Component.VC.Tools.ARM"
- remove "arm" case from src\coreclr\build-runtime.cmd
- Remove win-arm32 cross-components builds case from eng\Subsets.props. I think that would be:
<ItemGroup Condition="(('$(ClrRuntimeBuildSubsets)' != '' and '$(PrimaryRuntimeFlavor)' == 'CoreCLR' and '$(TargetsMobile)' != 'true') or $(_subset.Contains('+clr.crossarchtools+'))) and $([MSBuild]::IsOsPlatform(Windows)) and '$(TargetArchitecture)' == 'arm' and '$(BuildArchitecture)' == 'x64'">
<ProjectToBuild
Include="$(CoreClrProjectRoot)runtime.proj"
AdditionalProperties="%(AdditionalProperties);
ClrCrossComponentsSubset=true;
HostArchitecture=x86;
PgoInstrument=false;
NoPgoOptimize=true;
CrossBuild=false;
CMakeArgs=$(CMakeArgs) -DCLR_CROSS_COMPONENTS_BUILD=1"
Category="clr" />
</ItemGroup>
Yes, we have been closing win-arm32 issues as won't fix for a while now. If there are any still left, feel free to close them. |
* Remove Windows arm32 packages. Ref: dotnet/runtime#86065 * Remove some windows-arm stuff from llvm.proj
* Remove Windows arm32 packages. Ref: dotnet/runtime#86065 * Remove some windows-arm stuff from llvm.proj (cherry picked from commit c01ca3b)
No description provided.