Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono][tests] Run Mono iOS sample as functional test on the simulator and maccatalyst on Helix #86578

Merged
merged 31 commits into from
Jun 11, 2023

Conversation

kotlarmilos
Copy link
Member

@kotlarmilos kotlarmilos commented May 22, 2023

This PR adds Mono iOS app as a functional test on the simulator and maccatalyst to the Helix.

/cc: @ivanpovazan @filipnavara

@kotlarmilos kotlarmilos added this to the 8.0.0 milestone May 22, 2023
@kotlarmilos kotlarmilos self-assigned this May 22, 2023
@ghost
Copy link

ghost commented May 22, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR enables Mono iOS sample on Helix. Additionally, it aims to enable/test the Native AOT sample on Helix.

Author: kotlarmilos
Assignees: kotlarmilos
Labels:

area-Infrastructure-mono

Milestone: 8.0.0

@kotlarmilos
Copy link
Member Author

/azp run runtime-ioslike

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos
Copy link
Member Author

/azp run runtime-ioslike

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos
Copy link
Member Author

/azp run runtime-ioslike

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos
Copy link
Member Author

/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@kotlarmilos
Copy link
Member Author

/azp run runtime-ioslike,runtime-ioslikesimulator

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kotlarmilos
Copy link
Member Author

/azp run runtime-ioslikesimulator

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos
Copy link
Member Author

/azp run runtime-maccatalyst

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos kotlarmilos marked this pull request as ready for review May 25, 2023 12:18
@kotlarmilos kotlarmilos changed the title [mono][tests] Run Mono iOS sample as functional test on Helix [mono][tests] Run Mono iOS sample as functional test on the simulator and maccatalyst on Helix Jun 6, 2023
@kotlarmilos
Copy link
Member Author

kotlarmilos commented Jun 6, 2023

/azp run runtime-ioslikesimulator

@azure-pipelines

This comment was marked as off-topic.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos
Copy link
Member Author

/azp run runtime-ioslikesimulator

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@ivanpovazan ivanpovazan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

I just added a small note in the review, but is not a blocker.

src/mono/sample/iOS/Program.csproj Show resolved Hide resolved
src/mono/sample/iOS/Program.csproj Outdated Show resolved Hide resolved
@kotlarmilos
Copy link
Member Author

/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@kotlarmilos
Copy link
Member Author

/azp run runtime-maccatalyst

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos
Copy link
Member Author

The tests are passing locally and on the CI. @ivanpovazan Thank you for valuable feedback!

@kotlarmilos kotlarmilos merged commit 19712d9 into dotnet:main Jun 11, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants