Fix possible stack overflow in TotalOrderIeee754Comparer #86593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
dotnet-issue-labeler
bot
added
the
needs-area-label
vcsjones
added
area-System.Numerics
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/area-system-numerics Issue DetailsIf an (incorrectly implemented) T for This changes the check to treat the value as unsigned. In doing so, that causes the negative value to go in to to
|
stephentoub
approved these changes
May 22, 2023
stephentoub
reviewed
May 22, 2023
src/libraries/System.Private.CoreLib/src/System/Numerics/TotalOrderIeee754Comparer.cs
Show resolved
Hide resolved
tannergooding
approved these changes
May 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an (incorrectly implemented) T for
TotalOrderIeee754Comparerreturns a negative value forGetSignificandByteCount, this will stack overflow.This changes the check to treat the value as unsigned. In doing so, that causes the negative value to go in to to
new bytepath instead of thestackalloc bytepath, which results in a runtime exception instead of a stack overflow, which takes down the process.