Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser] fix legacy interop tests #87001

Merged
merged 4 commits into from
Jun 2, 2023

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Jun 1, 2023

By renaming test project I unknowingly excluded it from CI in #75122 and it was not running there since.

@pavelsavara pavelsavara added this to the 8.0.0 milestone Jun 1, 2023
@pavelsavara pavelsavara requested a review from maraf June 1, 2023 12:30
@pavelsavara pavelsavara self-assigned this Jun 1, 2023
@ghost
Copy link

ghost commented Jun 1, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

By renaming test project I excluded it from CI in #75122 and it was not running there since.

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript

Milestone: 8.0.0

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

image

CI failures are unrelated

@pavelsavara pavelsavara marked this pull request as ready for review June 2, 2023 09:26
@pavelsavara pavelsavara requested review from lewing and kg as code owners June 2, 2023 09:26
Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@pavelsavara pavelsavara merged commit 0214a04 into dotnet:main Jun 2, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jul 2, 2023
@pavelsavara pavelsavara deleted the browser_fix_legacy_tests branch September 2, 2024 15:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants