Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open generic enumerable resolution fix #87017 #87025

Conversation

mesakomarevich
Copy link

@mesakomarevich mesakomarevich commented Jun 1, 2023

  • Fixed erroneous resolution of enumerables
  • We now attempt to match each descriptor against both the service type and implementation type of cached call sites to account for slot mismatches, which can occur when a call site is cached, such that the slot order of the cached call sites does not match the expected order of descriptors
  • Added unit tests to validate said functionality

Fixes #87017

We now attempt to match each descriptor against both the service type
and implementation type of cached call sites to account for slot mismatches

Added unit test to validate this functionality

Fix dotnet#87017
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jun 1, 2023
@ghost
Copy link

ghost commented Jun 1, 2023

Tagging subscribers to this area: @dotnet/area-extensions-dependencyinjection
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Fixed erroneous resolution of enumerables
  • We now attempt to match each descriptor against both the service type and implementation type of cached call sites to account for slot mismatches, which can occur when a call site is cached, such that the slot order of the cached call sites does not match the expected order of descriptors
  • Added unit tests to validate said functionality
Author: mesakomarevich
Assignees: -
Labels:

area-Extensions-DependencyInjection

Milestone: -

@mesakomarevich
Copy link
Author

@mesakomarevich please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"

Contributor License Agreement

@dotnet-policy-service agree company="Attabotics"

@steveharter
Copy link
Member

Thanks @mesakomarevich but closing per discussion in #87017 (comment) this previous PR addresses both #87017 and #79938.

@steveharter steveharter closed this Jun 8, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jul 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Extensions-DependencyInjection community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Microsoft DI resolves enumerables incorrectly when a matching ServiceType has already been resolved
2 participants