Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Add some JIT helper functions to throw common corlib exceptions. #87044

Merged
merged 1 commit into from
Jun 27, 2023
Merged

[wasm] Add some JIT helper functions to throw common corlib exceptions. #87044

merged 1 commit into from
Jun 27, 2023

Conversation

vargaz
Copy link
Contributor

@vargaz vargaz commented Jun 2, 2023

No description provided.

@vargaz
Copy link
Contributor Author

vargaz commented Jun 2, 2023

/azp run runtime-wasm

@ghost ghost assigned vargaz Jun 2, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vargaz
Copy link
Contributor Author

vargaz commented Jun 2, 2023

This reduces wasm executable sizes somewhat because it replaces:
call void @mini_llvmonly_throw_corlib_exception(i32 157)
with
call void @mini_llvmonly_throw_invalid_cast_exception()
So the generated code doesn't have to pass the argument any more.

This was referenced Jun 2, 2023
Closed
Open
Closed
@vargaz
Copy link
Contributor Author

vargaz commented Jun 2, 2023

Failures appear unrelated.

@vargaz vargaz requested review from fanyang-mono and lewing June 15, 2023 20:42
@vargaz
Copy link
Contributor Author

vargaz commented Jun 20, 2023

/azp run runtime

@vargaz
Copy link
Contributor Author

vargaz commented Jun 20, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Jun 20, 2023
Closed
@vargaz vargaz merged commit f777fe6 into dotnet:main Jun 27, 2023
@vargaz vargaz deleted the wasm-aot-throw branch June 27, 2023 18:06
@ghost ghost locked as resolved and limited conversation to collaborators Jul 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fanyang-mono fanyang-mono fanyang-mono approved these changes

@lambdageek lambdageek Awaiting requested review from lambdageek

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

@thaystg thaystg Awaiting requested review from thaystg thaystg is a code owner

@lewing lewing Awaiting requested review from lewing

Assignees

@vargaz vargaz

Labels
area-VM-meta-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vargaz @fanyang-mono