[hot reload][mono] Implement support for adding static and instance fields to generic classes #87285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet/roslyn#68293 we get an error if we add a generic field and try to use it during the same edit. workaround is to do two separate edits
ldsflda seems to be working
dotnet-issue-labeler
bot
added
the
area-EnC-mono
ghost
assigned 
|
cc @mikelle-rogers coreclr doesn't like the new test |
lambdageek
changed the title
|
Also found an issue where mono does loads of added valuetype fields incorrectly. That warrants its own non-generic test (the existing tests only try small primitive types, not structs like |
This was referenced Jun 9, 2023
lambdageek
force-pushed
the
explore-hot-ginst
branch
from
e1f018b to
b7c52f7
Compare
lambdageek
requested review from
BrzVlad,
vargaz,
kotlarmilos,
thaystg and
marek-safar
as code owners
|
@fanyang-mono please take a look |
This was referenced Jun 14, 2023
lambdageek
force-pushed
the
explore-hot-ginst
branch
from
47f6dd0 to
82cd412
Compare
lambdageek
force-pushed
the
explore-hot-ginst
branch
from
82cd412 to
b56cdf9
Compare
2 tasks
fanyang-mono
approved these changes
Jun 15, 2023
yes! thank you! |
BrzVlad
reviewed
Jun 16, 2023
BrzVlad
approved these changes
Jun 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86111