JIT: Handle commas in physical promotion #87401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Physical promotion was not properly handling accounting in the presence of commas and was not properly handling struct commas during replacement.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsPhysical promotion was not properly handling accounting in the presence of commas and was not properly handling struct commas during replacement. No diffs are expected as we don't see any struct commas in physical promotion currently.
|
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
cc @dotnet/jit-contrib PTAL @EgorBo No diffs as expected, physical promotion enabled, old promotion disabled. Small TP hit. |
Synchronized methods actually can create struct commas on the form [000033] -AC-G------ ▌ RETURN struct
[000090] -AC-G------ └──▌ COMMA struct
[000087] DA--------- ├──▌ STORE_LCL_VAR struct<S, 16> V11 tmp8
[000032] -------N--- │ └──▌ LCL_VAR struct<S, 16> V01 loc0
[000089] --C-G------ └──▌ COMMA struct
[000086] --C-G------ ├──▌ CALL help void CORINFO_HELP_MON_EXIT
[000085] ----------- arg0 │ ├──▌ LCL_VAR ref V00 this
[000084] ----------- arg1 │ └──▌ LCL_ADDR long V09 tmp6 [+0]
[000088] -------N--- └──▌ LCL_VAR struct<S, 16> V11 tmp8 However, we don't promote any of these structs currently, but I started hitting these in #87410. |
EgorBo
approved these changes
Jun 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Physical promotion was not properly handling accounting in the presence of commas and was not properly handling struct commas during replacement.
No diffs are expected as we don't see any struct commas in physical promotion currently.