Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable disabled BigInteger tests. #87640

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

eiriktsarpalis
Copy link
Member

Fix #63802.

The BigInteger failures were fixed by #87383 and the record unit tests are caused by the fact that netfx doesn't have the IsExternalInit class defined.

@ghost
Copy link

ghost commented Jun 15, 2023

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #63802.

The BigInteger failures were fixed by #87383 and the record unit tests are caused by the fact that netfx doesn't have the IsExternalInit class defined.

Author: eiriktsarpalis
Assignees: -
Labels:

area-System.Text.Json

Milestone: -

@eiriktsarpalis eiriktsarpalis requested review from layomia and krwq June 15, 2023 19:50
@eiriktsarpalis eiriktsarpalis added this to the 8.0.0 milestone Jun 15, 2023
@eiriktsarpalis eiriktsarpalis merged commit 64cab8f into dotnet:main Jun 15, 2023
@eiriktsarpalis eiriktsarpalis deleted the enable-biginteger-tests branch June 15, 2023 22:45
@ghost ghost locked as resolved and limited conversation to collaborators Jul 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.Text.Json.SourceGeneration.Tests have issues with BigInteger and records on netfx
2 participants