Check Locations length before accessing #87659
Conversation
dotnet-issue-labeler
bot
added
the
area-Tools-ILLink
ghost
added
the
linkable-framework
|
Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas Issue DetailsFixes an I'm also adding checks in the other places this analyzer accesses
|
|
|
||
| foreach (var parameter in method.Parameters) { | ||
| foreach (var diagnostic in ProcessGenericParameters (parameter.Type, parameter.Locations[0])) | ||
| context.ReportDiagnostic (diagnostic); | ||
| if (parameter.Locations.Length > 0) { |
There was a problem hiding this comment.
This check is the only one necessary to fix the reported issue.
src/tools/illink/src/ILLink.RoslynAnalyzer/DynamicallyAccessedMembersAnalyzer.cs
Outdated
Show resolved
Hide resolved
|
Wasm tests are still failing with the same error: We use the latest 8.0 sdk to run the tests, so we would need to wait for this change to show up in a new sdk. |
src/tools/illink/src/ILLink.RoslynAnalyzer/DynamicallyAccessedMembersAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/tools/illink/src/ILLink.RoslynAnalyzer/DynamicallyAccessedMembersAnalyzer.cs
Outdated
Show resolved
Hide resolved
ghost
added
the
needs-author-action
ghost
removed
the
needs-author-action
| public static async Task VerifyAnalyzerAsync (string src, (string, string)[]? analyzerOptions = null, IEnumerable<MetadataReference>? additionalReferences = null, params DiagnosticResult[] expected) | ||
| public static async Task VerifyAnalyzerAsync ( | ||
| string src, | ||
| bool consoleApplication, |
There was a problem hiding this comment.
Nit: Make it false by default to avoid changing so many lines - and also to simplify the most common usage.
There was a problem hiding this comment.
I couldn't find a good way to make it optional - the second argument seems to be always treated as part of the params[] args: https://sharplab.io/#v2:C4LgTgrgdgNAJiA1AHwMIDoCyAKARACwFMAbYge1xgAIBGamgSgG4BYAKHYAEAmK1KgN7sqIqpwDMYmgDYxAFio5ONAAxUAztQBGZMsSpaqAXioAzAIbF1hagAdzYcwFt1VAJZRgAbQC6VBwDm6gyCAL7soUA===.
ghost
locked as resolved and limited conversation to collaborators
Fixes an
IndexOutOfRangeExceptionthrown by the analyzer when analyzing method parameters for the implicitly generated Main method when using top-level statements. These method parameters don't have location info because they are not in user code.I'm also adding checks in the other places this analyzer accesses
Locations[0], to be safe. But only one of these accesses was causing the crash reported in #87647. @vitek-karas @agocke please let me know if you have opinions on whether we should do a more targeted fix.Fixes #87647