[wasm] Fix WasmBase.IsSupported in AOT #88523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `WasmBase` to `supported_wasm_intrinsics group`. That way we handle the `WasmBase`
correctly when SIMD is enabled (default case). Before this change the `emit_hardware_intrinsics`
returned false for the `WasmBase.IsSupported`, because it wasn't in the group and we are using
it for the whole `S.R.I.Wasm` namespace.
Example of the emitted code difference to confirm the fix:
(func corlib_ulong_Log2_ulong(param i64, i32) (result i64)) code size difference: -30 bytes
...
local.get $0
i64.const
- i64.shr.u
- i32.wrap.i64
- local.tee $1
- i32.eqz
+ i64.or
+ i64.clz
+ i64.const
+ i64.xor
- if
- local.get $0
- i32.wrap.i64
- i32.const
- i32.or
- local.get $1
- call corlib_System_Numerics_BitOperations_Log2SoftwareFallback_uint
- i64.extend.i32.u
- return
-
- local.get $1
- i32.const
- i32.or
- local.get $1
- call corlib_System_Numerics_BitOperations_Log2SoftwareFallback_uint
- i32.const
- i32.add
- i64.extend.i32.u
radekdoulik
requested review from
vargaz,
lambdageek and
SamMonoRT
as code owners
vargaz
approved these changes
Jul 7, 2023
This was referenced Jul 7, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
WasmBasetosupported_wasm_intrinsics group. That way we handle theWasmBasecorrectly when SIMD is enabled (default case). Before this change theemit_hardware_intrinsicsreturned false for theWasmBase.IsSupported, because it wasn't in the group and we are using it for the wholeS.R.I.Wasmnamespace.Example of the emitted code difference to confirm the fix: