Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tar: Only treat reparse points marked as junctions or symlinks as actual tar symlinks #89102

Closed
wants to merge 10 commits into from
Closed

Tar: Only treat reparse points marked as junctions or symlinks as actual tar symlinks #89102

wants to merge 10 commits into from

Commits on Jul 18, 2023

  1. Move GetFindData method from FileSystem.Windows.cs to Interop.FindFir… 

    …stFileEx.cs for shared consumption.
    @carlossanlop
    carlossanlop committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    507f169 View commit details
    Browse the repository at this point in the history

  2. Consume GetFindData in TarWriter.Windows.cs to determine if a reparse… 

    … point is a junction or a symbolic link, in which case the filesystem object will be treated as a tar symbolic link. All other reparse points will be treated as regular files.
    @carlossanlop
    carlossanlop committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    326846a View commit details
    Browse the repository at this point in the history

  3. Remove unused using directives.

    @carlossanlop
    carlossanlop committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    689064c View commit details
    Browse the repository at this point in the history

  4. Create method that chooses the right regular file enum value for the … 

    …specified format and consume it in TarWriter.Unix.cs and TarWriter.Windows.cs.
    @carlossanlop
    carlossanlop committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    417585a View commit details
    Browse the repository at this point in the history

  5. Also add a helper method in tests to choose the right regular file en… 

    …um value for the specified format.
    @carlossanlop
    carlossanlop committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    5348435 View commit details
    Browse the repository at this point in the history

  6. Add windows-only tests that create junctions and add them to an archi… 

    …ve, verify they are added as symbolic links entries.
    @carlossanlop
    carlossanlop committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    ddd8c8f View commit details
    Browse the repository at this point in the history

  7. Move tag retrieval into if

    @carlossanlop
    carlossanlop committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    53e2ad8 View commit details
    Browse the repository at this point in the history

  8. Throw IOException for all other reparse points.

    @carlossanlop
    carlossanlop committed Jul 18, 2023
    2 Configuration menu
    Copy the full SHA
    9d17d9c View commit details
    Browse the repository at this point in the history

  9. Add test that throws when attempting to add an unsupported appexeclin… 

    …k file to an archive.
    @carlossanlop
    carlossanlop committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    e934e76 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Apply suggestions from code review

    @jozkee
    jozkee authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    375f1b8 View commit details
    Browse the repository at this point in the history