Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nullable return from ConstructorInvoker.Invoke() #89448

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

steveharter
Copy link
Member

The nullability for recent issue #88415 was incorrect for ConstructorInvoker's Invoke() return value - it shouldn't be nullable.

This is unlike ConstructorInfo.Invoke() which can return null if the incoming obj parameter is non-null in which case the constructor is called on obj without allocation. Since ConstructorInvoker doesn't have an obj parameter, it will always allocate and return an object (and call the constructor on it).

Mail sent to FXDC for approval request.

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost assigned steveharter Jul 25, 2023
@ghost
Copy link

ghost commented Jul 25, 2023

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

The nullability for recent issue #88415 was incorrect for ConstructorInvoker's Invoke() return value - it shouldn't be nullable.

This is unlike ConstructorInfo.Invoke() which can return null if the incoming obj parameter is non-null in which case the constructor is called on obj without allocation. Since ConstructorInvoker doesn't have an obj parameter, it will always allocate and return an object (and call the constructor on it).

Mail sent to FXDC for approval request.

Author: steveharter
Assignees: -
Labels:

area-System.Reflection, new-api-needs-documentation

Milestone: -

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkotas jkotas merged commit 620deb8 into dotnet:main Jul 25, 2023
168 checks passed
@steveharter steveharter deleted the NonNullableConstructorInvoker branch July 26, 2023 14:05
@ghost ghost locked as resolved and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants