Support breakpoints on AVX-512 instructions #89705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @tommcdon Issue Detailsnull
|
filipnavara
added
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue Detailsnull
|
BruceForstall
added
area-Diagnostics-coreclr
and removed
area-CodeGen-coreclr
|
Tagging subscribers to this area: @tommcdon Issue Detailsnull
|
|
@noahfalk @mikem8361 @hoyosjs This is ready to be reviewed. |
BruceForstall
force-pushed
the
UpdateAmd64DebuggerDisasm
branch
from
abd9e7a to
958208f
Compare
Regenerate with gdb 12. Fix various bugs in the table generation, such as due to incorrect ModRM/reg escape handling, and new instructions.
Especially, removed 3DNow, XOP. Also, update README.md
Due to removing XOP instructions
BruceForstall
force-pushed
the
UpdateAmd64DebuggerDisasm
branch
from
958208f to
ae4bc4c
Compare
tommcdon
approved these changes
Aug 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support AVX-512 EVEX instruction encodings in debugger patch decode. This allows setting breakpoints on EVEX encoded instructions with RIP-relative memory operands.
This is done by extending the existing table generation and usage mechanism.
In addition to the EVEX addition, various fixes were made to the non-EVEX decodings. Partially this is because the tables were regenerated using gdb 12 (compared to the original construction several years ago), which appears to have some disassembly fixes. In addition, the C# table generating code was updated to compile with the current compiler. Also, various bugs I noticed in the table generation were fixed.
Also, obsolete AMD 3DNow! and XOP instructions and encodings were removed, to avoid their complications.
Resolves #87843