Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mono]: Fix iOS/Android sample diagnostics config. #89725

Merged
merged 1 commit into from
Aug 2, 2023
Merged

[Mono]: Fix iOS/Android sample diagnostics config. #89725

merged 1 commit into from
Aug 2, 2023

Conversation

lateralusX
Copy link
Member

Update iOS/Android sample diagnostics config to align with .net8 changes.

  • marshal-ilgen is a default component that needs to be included in component specifications.
  • Make sure properties including "," don't get truncated when passed to msbuild for iOS samples.
  • Apply diagnostics defaults to maccatalyst sample build (when enabled).

@lateralusX lateralusX requested a review from marek-safar as a code owner July 31, 2023 15:31
@ghost ghost assigned lateralusX Jul 31, 2023
@ghost
Copy link

ghost commented Jul 31, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Update iOS/Android sample diagnostics config to align with .net8 changes.

  • marshal-ilgen is a default component that needs to be included in component specifications.
  • Make sure properties including "," don't get truncated when passed to msbuild for iOS samples.
  • Apply diagnostics defaults to maccatalyst sample build (when enabled).
Author: lateralusX
Assignees: lateralusX
Labels:

area-Infrastructure-mono
Milestone: -

@lateralusX lateralusX requested a review from akoeplinger August 1, 2023 07:18
@lateralusX lateralusX merged commit 63f4c6e into dotnet:main Aug 2, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vargaz vargaz vargaz approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

Assignees

@lateralusX lateralusX

Labels
area-Infrastructure-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lateralusX @vargaz