Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Consistently use '0x' as the hex specifier #89773

Merged
merged 1 commit into from
Aug 2, 2023
Merged

JIT: Consistently use '0x' as the hex specifier #89773

merged 1 commit into from
Aug 2, 2023

Conversation

jakobbotsch
Copy link
Member

Fix #81329

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 1, 2023
@ghost ghost assigned jakobbotsch Aug 1, 2023
@ghost
Copy link

ghost commented Aug 1, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #81329

Author: jakobbotsch
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@kasperk81
Copy link
Contributor

thanks!

@build-analysis build-analysis bot mentioned this pull request Aug 1, 2023
Closed
@jakobbotsch
Copy link
Member Author

cc @dotnet/jit-contrib PTAL @kunalspathak @BruceForstall. The failure is #88586.

@build-analysis build-analysis bot mentioned this pull request Aug 1, 2023
Closed
BruceForstall
BruceForstall approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you show a few examples of disasm diffs? (I don't care about jitdump diffs)

@jakobbotsch
Copy link
Member Author

Can you show a few examples of disasm diffs?

Here's an example: https://www.diffchecker.com/J2ZDLVd4/

@jakobbotsch jakobbotsch merged commit 59f57a8 into dotnet:main Aug 2, 2023
128 of 135 checks passed
@jakobbotsch jakobbotsch deleted the consistent-hex-specifier branch August 2, 2023 08:53
@ghost ghost locked as resolved and limited conversation to collaborators Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BruceForstall BruceForstall BruceForstall approved these changes

@kunalspathak kunalspathak Awaiting requested review from kunalspathak

Assignees

@jakobbotsch jakobbotsch

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hex number format in .net 7 jit assembly
3 participants
@jakobbotsch @kasperk81 @BruceForstall