Fix handling ThreadAbortException at the end of catch #89781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the catch handler for ThreadAbortException exits, the exception needs to be rethrown immediatelly. This change makes that work.
|
This change was tested with a slightly modified. sample from an original #12739 on Linux amd64, macOS arm64. Linux Arm testing is in progress, I am stuck with some VS Code issues. |
|
Can we add a |
|
@jkotas we actually have a test like that, it just contains workaround for Unix. I just needed to remove that workaround. |
jkotas
approved these changes
Aug 1, 2023
am11
reviewed
Aug 1, 2023
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
|
Hmm, it seems that macOS x64 is failing in the test executing the new code path. I need to investigate it. |
The non-local label was preventing unwinding through \stub\()_RspAligned
|
I've found the macOS x64 issue - the non-local |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the catch handler for ThreadAbortException exits, the
exception needs to be rethrown immediately. This was not
implemented on Unix and this change makes that work on
Unix amd64, arm64 and arm.
Close #72703