Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for TypeIdentifierAttribute #89882

Merged
merged 3 commits into from
Aug 4, 2023

Conversation

steveharter
Copy link
Member

@steveharter steveharter added area-System.Reflection test-enhancement Improvements of test source code labels Aug 2, 2023
@steveharter steveharter self-assigned this Aug 2, 2023
@steveharter steveharter requested review from jkotas and buyaa-n August 2, 2023 21:07
@ghost
Copy link

ghost commented Aug 2, 2023

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

Adds a test for #73103 which was previously fixed in 0a587ff#diff-ac44b8df606ec5a6fd2ec32bd3c61853f77cfb6ecef622b7ce1bfc5ed245edf4L796

Fixes #73103

Author: steveharter
Assignees: steveharter
Labels:

area-System.Reflection, test-enhancement

Milestone: -

@jkotas
Copy link
Member

jkotas commented Aug 2, 2023

TypeEquivalence is only supported in full CoreCLR. The test is going to fail in Mono and native AOT.

@jkotas
Copy link
Member

jkotas commented Aug 2, 2023

Maybe add a new property to PlatformDetection for type equivalence.

@steveharter steveharter merged commit c2a0416 into dotnet:main Aug 4, 2023
@steveharter steveharter deleted the AddTypeIdentifierTest branch August 4, 2023 14:28
@ghost ghost locked as resolved and limited conversation to collaborators Sep 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Reflection test-enhancement Improvements of test source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AF: System.RuntimeType.CheckValue trying to reflection invoke method with equivalent types
2 participants